Differential D10896

Typeahead: Do not use locale-specific comparisons
AbandonedPublic
Actions

Authored by matmarex on Nov 24 2014, 12:15 AM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6616: Typeahead uses locale-specific comparison

Summary

Things can't be assumed to be in user's locale, and using it can lead to some items not being available. Use the canonical comparison. See T6616.

Test Plan

In Phabricator, try assigning a project to a task, verify that the typeahead dropdown still works.

(I haven't tested this change.)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 3135
Build 3141: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

matmarex updated this revision to Diff 26176.Nov 24 2014, 12:15 AM

matmarex retitled this revision from to Typeahead: Do not use locale-specific comparisons.

matmarex updated this object.

matmarex edited the test plan for this revision. (Show Details)

matmarex set the repository for this revision to rJX Javelin.

matmarex added projects: Javelin, Phabricator.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 24 2014, 12:15 AM

Herald added a subscriber: epriestley. · View Herald Transcript

matmarex added a task: T6616: Typeahead uses locale-specific comparison.Nov 24 2014, 12:15 AM

Harbormaster completed remote builds in B3135: Diff 26176.Nov 24 2014, 12:16 AM

Meh.

Revision Contents
Changeset List

Path

Size

src/

lib/

control/

typeahead/

normalizer/

TypeaheadNormalizer.js

2 lines

source/

TypeaheadSource.js

13 lines

Diff 26176

View Options

src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js