@epriestley, is this code review going to be accepted? Or do you know the status of it? Is there something that I can do to help it get accepted? This is something that I was looking at extending myself but then I found this code review.

I am sorry, I completely missed that one. $verb_formatted can also be removed. Sorry that I did not catch that.

• Fixed trailing whitespace

• Made changes requested by epriestley and added checking for invalid dates

Thanks for your help! I will get those changes made right away.

• Changed the priority_accepted_colors to web_to_terminal_colors map and mapped all colors found in the palette

Actually I like that idea a lot. I can see how terminalColor could be overkill. But I like the web color map. Would you like to to just map the default configuration colors, or would you like me to map basic ones as well? I will get to work on that right now.

This diff is supporting D8735

Currently this does not allow for users to define any colors other than the basics:

• magenta
• red
• yellow
• green
• blue
• cyan

and have them show up correctly in the terminal. Another option (which I feel would be better and would also allow us to continue supporting the default configuration) would be to add a terminalColor property to the maniphest.priorities config and allowing the user to define a color that will be displayed on phabricator and a color that arc tasks will display.

Added the changes requested by epriestley.
Now arc tasks shows the actual human-readable status and a green bar for open or red bar for closed. Also, if there is a newer version of arc using an older version of phabricator, the status column will not be displayed so that we do not have any errors thrown.

Here are the fixes. I am happy to do it. I am excited to continue contributing to these projects. My team and I are going to begin using phabricator and arcanist so there are improvements that I will hopefully be able to make as we find things that we would like improved.

Update to change the base commit for the diff

Added a statusName property as well which will be used by arc tasks in D8732.

I'm sorry I hadn't seen the task. I should have checked first. I think that adding statusName would definitely be of use. That could also be potentially used in the arc tasks display instead of Open/Closed don't you think? I think that would be much more informative and we can leave a green bar signifying open and red signifying closed.