@epriestley, can you confirm that the above patch should disable the draft state? I have applied it to GHC's Phabricator deployment yet we are still seeing Differentials opened in draft state.

GHC recently upgraded its Phabricator installation and has been rather unpleasantly affected by this feature. We have multi-hour CI jobs, which often queue to a day or so of builds. Making contributors wait this long before receiving feedback is turning out to be rather problematic.

I agree that there is no sensible technical reason for the broken network policies that prompted my comment and understand your reasons for preferring to punt on a technical solution. Thanks for your thoughtful remarks.

Some GHC contributors have had some trouble with the fact that there is no choice in staging area URL. Unfortunately, some users appear to be behind corporate firewalls which block anything but http and https. We use SSH for our staging repository, which is of course problematic for these contributors. There are a few comments above from Nov 2015 which suggest that we aren't the only ones who have this issue.

GHC appears to be running into this limitation. We would prefer to use anonymous HTTP access with our build bots; is there any hope that this will be fixed in the near-term?

GHC would also find support for importing keys from Github useful; we are currently working on rolling out a Diffusion-hosted staging area for use with Harbormaster but the need for contributors to submit their key to yet another Phab feels like unnecessary friction.

You'll still need to go there and fill out all the stuff you would have filled out in your commit message. That is, this flow would drop you at the screen right after you copy/paste:

Sounds good to me. Thanks again!

The documentation contains this paragraph,

In D14535#163975, @epriestley wrote:

This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:

• phutil_utf8_strtolower() has better behavior than strtolower() on some utf8 inputs.
• phutil_json_decode() has better behavior (throws a detailed exception) on invalid JSON than json_decode() (returns false).

Thanks for the review!

Done.

Fair enough. Thanks for your thoughtful reply.

Correct comments

@epriestley, the amended text should clarify my goals here.