Just wanted to chime in that I've just encountered this as well. Just did an upgrade, and hundreds (possibly thousands?) of old commits are somehow being reprocessed and are pushed to the feed. It's been processing for a couple of hours now, no idea how much work remains....

Yeah, I understand, although too bad if that task is as low-pri and as large an undertaking as it seems. :/

Any progress on this?

Any chance this could be speeded up if we were to sponsor some of the development on this?

Big yes, please to this. I came across this task when looking into a way to exclude our Python tests when creating diffs when only our front-end JS code has been touched, for instance. It seems this feature will allow just that?

In T8463#119247, @epriestley wrote:

Do the problematic revisions mention a user with @username in the summary or test plan?

Seems to work fine, which doesn't suprise me ref. my last comment...

How should I do that? But we have further info. A collegue of mine checked out my branch, and successfully created the diff I was unable to. So this seems to be specific to my user...

FYI, I also created creating the diff manually through Differential on the web interface. Same exception occured.

I'm sorry for bumping this, but I'm actually totally stuck, and can't seem to find any way to create revisions. We just upgraded Phabricator again to see if this had been resolved since our initial upgrade this weekend, but no go...

I think we're bitten by the same issue, although nothing to do with Conduit on our end as far as I can tell. Creating a new revision with arc diff crashes for me today, and that is after we upgraded Phabricator this weekend. Stack trace:

In T7447#113660, @alancrisp wrote:

Most of the issues our team run into stem from the fact that we can't toggle the comments temporarily in order to get a distraction free view of the code. Some of our inlines spark some quite lengthy discussions which can sometimes get in the way when you only need to see the code.

We do use the diff of diffs feature heavily which helps this, but it's not always an option for a reviewer due to the fact we generally require two accepts on a diff before it lands. It's not uncommon for a diff to be in a second or third iteration by the time a second reviewer starts their own review from scratch. For the second reviewer, seeing previous discussions isn't always useful - it can be, but we also find that often it's desirable just to hide the noise for a minute to view the current code in its entirety before continuing with the review.

In T7447#110476, @joshuaspence wrote:

In T7447#110475, @scohen wrote:

I don't know @epriestley, I found it really confusing to have my comment on a different line entirely.

+1

I'm sorry to say I don't for the life of me understand how "this feature (as it exists today) is a net improvement to Differential". See this screenshot from one of our reviews, which both hightlights the fact that the diff is terribly difficult to read, and even more important, has major issues with where the forward-moving comments appear:

In T7447#110375, @epriestley wrote:

As a reviewer, I think bringing "Done" comments forward is quite important: it makes it a lot easier for me to verify that they're really done. This is the #1 benefit I've reaped from this feature so far.

In T1460#109400, @asteinlein wrote:

In T1460#108778, @avivey wrote:

The Done state should maybe propagate to the replies of the comment?

Very much +1 to this.

In T7447#109397, @epriestley wrote:

In T1460#109396, @asteinlein wrote:

We're liking the new feature to mark inline comments as done, however, we dislike the change that makes old comments "stick" to updated diffs. This makes it much harder to read the new updated diff when there are lots of inline comments. Any plans to improve this somehow?

Can you explain your use case a little more? Why are there lots of inline comments? (See discussion earlier in this task.)

In T1460#108778, @avivey wrote:

The Done state should maybe propagate to the replies of the comment?

We're liking the new feature to mark inline comments as done, however, we dislike the change that makes old comments "stick" to updated diffs. This makes it much harder to read the new updated diff when there are lots of inline comments. Any plans to improve this somehow?

I haven't contributed anything to Phabricator yet, but this is a feature we need, so I might be able to take a stab at this. Any feedback whether this is something that will be accepted, and how complicated it might be?