Page MenuHomePhabricator

alancrisp (Alan Crisp)
UserEmail Not Verified

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2012, 8:48 PM (362 w, 1 d)
Availability
Available

Recent Activity

Jan 26 2016

exp10r3r awarded Roadmap a Love token.
Jan 26 2016, 9:01 AM

May 15 2015

alancrisp added a comment to T7447: Bring inline comments forward across revision updates.

Just to demonstrate, this one gave a couple of our devs some grief earlier today. The comments create so much noise you can barely see the loop being reviewed.

May 15 2015, 10:13 AM · Prioritized, Differential

May 13 2015

alancrisp added a comment to T7447: Bring inline comments forward across revision updates.

Most of the issues our team run into stem from the fact that we can't toggle the comments temporarily in order to get a distraction free view of the code. Some of our inlines spark some quite lengthy discussions which can sometimes get in the way when you only need to see the code.

May 13 2015, 4:52 PM · Prioritized, Differential

Apr 30 2015

alancrisp added a comment to T7447: Bring inline comments forward across revision updates.

If I'm a reviewer that has previously requested a change it can be useful to see the "Done" comments. If I'm a second reviewer coming along after two or more diffs it's not terribly useful to me and serves more as a distraction from the code I'm trying to review. That seems to be the consensus amongst my team anyway.

Apr 30 2015, 4:13 PM · Prioritized, Differential

Apr 29 2015

alancrisp added a comment to T7447: Bring inline comments forward across revision updates.

I'd have to agree that diffs seem much noisier now. For the way we use Differential at least, we generally find that older comments aren't all that useful and can actually get in the way depending on where they're placed (inside if blocks, for example).

Apr 29 2015, 3:49 PM · Prioritized, Differential

Nov 12 2014

alancrisp edited the content of Organizations Using Phabricator.
Nov 12 2014, 5:07 PM

Nov 4 2014

alancrisp added a comment to T731: Allow revisions to have alternate acceptance conditions.

A couple of our projects at work are responsible for handling some very sensitive data. As a result, we try to enforce much stricter rules on these, such as:

  • minimum of N approvals
  • no rejections (past or current)
  • N reviews from team (project) X, Y and Z
Nov 4 2014, 5:13 PM · Restricted Project, Restricted Project, Differential

Jun 11 2014

alancrisp added a comment to T4567: Allow moving of Project Board Columns.

This would be very useful in a couple of our projects, where the workboard columns roughly correspond to where a task is in the development process ('Needs Information', 'In Progress', 'Ready to Land', etc.).

Jun 11 2014, 10:27 AM · Workboards, Projects