Not super-familiar with PowerShell. If the issue linked above would be helpful to you, could you please add your requirements there and we can coordinate getting it in the Uber plugin? (I'm the maintainer)

I have a branch up that allows for non-differential builds to submit
harbormaster from Jenkins. I dropped it before the holidays since there
didn't seem to be much interest but can resurrect it if people are
interested:

Hey there, I am the maintainer of the Phabricator Jenkins plugin. I am working on adding coverage (and unit) reporting from Jenkins -> Harbormaster now that the API exists. You can track our progress here: https://github.com/uber/phabricator-jenkins-plugin/issues/34 (I wish I had a public Phabricator to develop this on :))

Sounds good.

It looks like this is the only one with $console->confirm() and $default_no.

Before:

@joshuaspence should I just submit a diff for this? Or am I misunderstanding the code?

And if this is indeed a bug, and not just me reading things terribly wrong, I'm happy to submit a patch to flip the binary values and rename, but wanted to make sure I wasn't wasting yall's time if this is just a misunderstanding on my part.

In other words, I was surprised to discover that the "Apply this patch" prompt default was "N", and it looks like before it was switched from phutil_console_confirm the default used to be "Y".

For an example of a conversion, see {D3151}

thanks for the quick replies! internally to uber, arc patch has served us well. we git reset --hard to the base revision, then patch --nocommit --nobranch. it wasn't until we open sourced our jenkins plugin and got this bug report that we even noticed this behavior. i'll follow the task you mentioned and update the jenkins plugin when a more robust solution is available.

nice!

I have a version of this with coverage support if you're interested:

@joshuaspence is this ready for review?

This is great, thanks for getting the tests passing!

I don't know if this is useful, or how to get the tests pass, but I like the functionality of go vet and I like phabricator, so maybe the two can be friends?

I also need to detect when the tool is not installed and output the proper warning. Unfortunately it's not as simple as a path check, since it's executed as go tool vet <file> and having go in the path is not enough.

eek, sorry about that!