Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Dec 13 2015

dim added a comment to D14755: Preserve the exit code of the diff command in binary_safe_diff.sh.

In D14755#167774, @epriestley wrote:

Happy to accept that if you want to double-check that it works and send me a diff for it.

Dec 13 2015, 10:35 AM

dim retitled D14759: Simplify diff exit code handling. from to Simplify diff exit code handling..

Dec 13 2015, 10:34 AM

dim added a revision to T9970: new files are empty for arc diff --create and --update : D14759: Simplify diff exit code handling..

Dec 13 2015, 10:34 AM · Subversion, Arcanist, Bug Report

dim added a comment to D14755: Preserve the exit code of the diff command in binary_safe_diff.sh.

Now that I think of it, the simplest possible way to get the desired effect (return 0 if diff succeeds, 1 if it does not succeed), is to use:

Dec 13 2015, 10:24 AM

dim added inline comments to D14755: Preserve the exit code of the diff command in binary_safe_diff.sh.

Dec 13 2015, 10:19 AM

Dec 12 2015

dim added a comment to T9970: new files are empty for arc diff --create and --update .

Right, I think I have found the cause. The binary_safe_diff.sh does not preserve the exit code of diff, and it returns 0 even if diff returned 1. Apparently returning 0 causes Subversion 1.9 to emit the file headers again.

Dec 12 2015, 6:59 PM · Subversion, Arcanist, Bug Report

dim retitled D14755: Preserve the exit code of the diff command in binary_safe_diff.sh from to Preserve the exit code of the diff command in binary_safe_diff.sh.

Dec 12 2015, 6:58 PM

dim added a comment to T9970: new files are empty for arc diff --create and --update .

For me this gives:

Dec 12 2015, 4:39 PM · Subversion, Arcanist, Bug Report

dim added a comment to T9970: new files are empty for arc diff --create and --update .

Hmm, this seems to be caused by Subversion 1.9 (which is the default in the FreeBSD ports collection). If I use Subversion 1.8 to run the svn diff --depth empty --diff-cmd '/usr/local/lib/php/arcanist/scripts/repository/binary_safe_diff.sh' -x -U32767 foo.txt command, the output is:

Dec 12 2015, 4:29 PM · Subversion, Arcanist, Bug Report

dim updated subscribers of T9970: new files are empty for arc diff --create and --update .

Adding Eitan, since he's our Phabricator wrangler.

Dec 12 2015, 6:16 AM · Subversion, Arcanist, Bug Report

dim added a comment to T9970: new files are empty for arc diff --create and --update .

I think the problem is because of Subversion automatic properties. For the FreeBSD Subversion repository, automatic properties get added, like this:

Dec 12 2015, 6:13 AM · Subversion, Arcanist, Bug Report