Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes
Ran various arc workflows under PHP 8.1.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- len2
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25608 Build 35422: Run Core Tests Build 35421: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1,017 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue.
#0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n')
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
| |
| 0 ms | AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed. | |
| 0 ms | AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed. | |
| 0 ms | AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed. | |
| 0 ms | AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed. | |
| View Full Test Results (1 Failed · 812 Passed · 64 Skipped) |