Page MenuHomePhabricator

Provide additional Arcanist PHP 8.1 fixes
ClosedPublic

Authored by epriestley on Dec 10 2021, 12:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 8:27 PM
Unknown Object (File)
Fri, Mar 22, 2:47 PM
Unknown Object (File)
Feb 21 2024, 7:37 PM
Unknown Object (File)
Feb 11 2024, 9:37 PM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Subscribers
None

Details

Summary

Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.

Test Plan

Ran various arc workflows under PHP 8.1.

Diff Detail

Repository
rARC Arcanist
Branch
len2
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25609
Build 35424: Run Core Tests
Build 35423: arc lint + arc unit

Unit TestsFailed

TimeTest
1,726 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): This patch has binary data. The PHP zlib extension is required to apply patches with binary data to git. Install the PHP zlib extension to continue. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(823): ArcanistBundle::newBase85Data('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...', '\n') #1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(813): ArcanistBundle->emitBinaryDiffBody('\x89PNG\r\n\x1A\n\x00\x00\x00\rIHD...')
0 msMethodCallFutureTestCase::testMethodCallFutureExceptions
EXCEPTION (RuntimeException): preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated #0 [internal function]: PhutilErrorHandler::handleError(8192, 'preg_replace():...', '/Users/epriestl...', 208) #1 /Users/epriestley/dev/core/lib/arcanist/src/serviceprofiler/PhutilServiceProfiler.php(208): preg_replace('/\\s{2,}/', ' ', NULL)
0 msMethodCallFutureTestCase::testMethodCallFutureSums
EXCEPTION (RuntimeException): preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated #0 [internal function]: PhutilErrorHandler::handleError(8192, 'preg_replace():...', '/Users/epriestl...', 208) #1 /Users/epriestley/dev/core/lib/arcanist/src/serviceprofiler/PhutilServiceProfiler.php(208): preg_replace('/\\s{2,}/', ' ', NULL)
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
View Full Test Results (3 Failed · 810 Passed · 64 Skipped)

Event Timeline

  • Fix unit tests and a handful of other errors.
  • Also fix service profiler test case.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2021, 12:42 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.