Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes
Ran various arc workflows under PHP 8.1.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- len2
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 25606 Build 35418: Run Core Tests Build 35417: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 0 ms | ArcanistBundleTestCase::testEncodeBase85 EXCEPTION (RuntimeException): Implicit conversion from float 777.0705882352942 to int loses precision
#0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistBundle.php(1025): PhutilErrorHandler::handleError(8192, 'Implicit conver...', '/Users/epriestl...', 1025)
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(983): ArcanistBundle::newBase85Data('\x00\x01\x02\x03\x04\x05\x06\x07\x08\t\n\v\f\r\x0E...', '\n', '64bit')
| |
| 0 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (RuntimeException): ltrim(): Passing null to parameter #1 ($string) of type string is deprecated
#0 [internal function]: PhutilErrorHandler::handleError(8192, 'ltrim(): Passin...', '/Users/epriestl...', 31)
#1 /Users/epriestley/dev/core/lib/arcanist/src/filesystem/PhutilDirectoryFixture.php(31): ltrim(NULL, '/')
| |
| 0 ms | ArcanistBundleTestCase::testTabEncoding EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated
#0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistDiffParser.php(928): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 928)
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistDiffParser.php(810): ArcanistDiffParser->parseChangeset(Object(ArcanistDiffChange))
| |
| 0 ms | ArcanistDiffParserTestCase::testGitRenames EXCEPTION (RuntimeException): preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
#0 [internal function]: PhutilErrorHandler::handleError(8192, 'preg_match(): P...', '/Users/epriestl...', 586)
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistDiffParser.php(586): preg_match('@^(?P<new>new) ...', NULL, NULL)
| |
| 0 ms | ArcanistDiffParserTestCase::testParser EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated
#0 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistDiffParser.php(928): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 928)
#1 /Users/epriestley/dev/core/lib/arcanist/src/parser/ArcanistDiffParser.php(348): ArcanistDiffParser->parseChangeset(Object(ArcanistDiffChange))
| |
| View Full Test Results (12 Failed · 772 Passed · 64 Skipped) |