Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes

Summary

Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.

Test Plan

Ran various arc workflows under PHP 8.1.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 10 2021, 12:21 AM

Harbormaster completed remote builds in B25606: Diff 51822.Dec 10 2021, 12:21 AM

epriestley requested review of this revision.Dec 10 2021, 12:21 AM

epriestley updated this revision to Diff 51823.Dec 10 2021, 12:36 AM

Harbormaster completed remote builds in B25607: Diff 51823.Dec 10 2021, 12:37 AM

epriestley updated this revision to Diff 51824.Dec 10 2021, 12:37 AM

Harbormaster completed remote builds in B25608: Diff 51824.Dec 10 2021, 12:37 AM

Fix unit tests and a handful of other errors.

Harbormaster completed remote builds in B25609: Diff 51825.Dec 10 2021, 12:39 AM

Also fix service profiler test case.

Harbormaster completed remote builds in B25610: Diff 51826.Dec 10 2021, 12:41 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2021, 12:42 AM

This revision was landed with ongoing or failed builds.

Closed by commit rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes.

Provide additional Arcanist PHP 8.1 fixes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 51827

src/configuration/ArcanistConfigurationManager.php

src/filesystem/PhutilDirectoryFixture.php

src/future/exec/ExecFuture.php

src/lint/linter/ArcanistXMLLinter.php

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistParentMemberReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

src/parser/ArcanistBundle.php

src/parser/ArcanistDiffParser.php

src/parser/PhutilBugtraqParser.php

src/parser/PhutilEmailAddress.php

src/parser/PhutilURI.php

src/parser/aast/api/AASTNodeList.php

src/serviceprofiler/PhutilServiceProfiler.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/utils/PhutilArray.php

src/utils/PhutilCallbackFilterIterator.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistWorkflow.php

support/lib/extract-symbols.php

Provide additional Arcanist PHP 8.1 fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51827

src/configuration/ArcanistConfigurationManager.php

src/filesystem/PhutilDirectoryFixture.php

src/future/exec/ExecFuture.php

src/lint/linter/ArcanistXMLLinter.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistParentMemberReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

src/parser/ArcanistBundle.php

src/parser/ArcanistDiffParser.php

src/parser/PhutilBugtraqParser.php

src/parser/PhutilEmailAddress.php

src/parser/PhutilURI.php

src/parser/aast/api/AASTNodeList.php

src/serviceprofiler/PhutilServiceProfiler.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/utils/PhutilArray.php

src/utils/PhutilCallbackFilterIterator.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistWorkflow.php

support/lib/extract-symbols.php

Provide additional Arcanist PHP 8.1 fixes
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/tests/ArcanistLinterTestCase.php