Paths

Table of Contentst

Differential D21703

Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
ClosedPublic
Actions

Authored by epriestley on Jul 21 2021, 4:54 PM.

Tags

None

Referenced Files

	F15392466: D21703.diff
	Sat, Mar 15, 3:22 PM

	F15384915: D21703.id.diff
	Fri, Mar 14, 9:10 PM

	F15373412: D21703.id.diff
	Wed, Mar 12, 3:46 PM

	Unknown Object (File)
	Sat, Mar 1, 10:25 PM

	Unknown Object (File)
	Sat, Mar 1, 10:25 PM

	Unknown Object (File)
	Sat, Mar 1, 10:24 PM

	Unknown Object (File)
	Thu, Feb 27, 1:27 AM

	Unknown Object (File)
	Mon, Feb 24, 8:46 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13660: Deprecate "PhutilExecPassthru->execute()" in favor of "PhutilExecPassthru->resolve()"

Commits

rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in…

Summary

Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it.

Test Plan

Grepped for "PhutilExecPassthru" and looked for callsites.
Ran GIT_SSH=.../ssh-connect git ls-remote origin to execute the "ssh-connect" code.
The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now.

Diff Detail

Repository

Branch

passthru1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25492
Build 35247: Run Core Tests
Build 35246: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 21 2021, 4:54 PM

Harbormaster completed remote builds in B25492: Diff 51689.Jul 21 2021, 4:56 PM

epriestley requested review of this revision.Jul 21 2021, 4:56 PM

epriestley mentioned this in D21705: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".Jul 21 2021, 5:11 PM

cspeckmim accepted this revision.Jul 21 2021, 5:18 PM

This revision is now accepted and ready to land.Jul 21 2021, 5:18 PM

Closed by commit rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in… (authored by epriestley). · Explain WhyJul 21 2021, 5:21 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPaf6cc0c934c4: Use "resolve()", not "execute()", for PhutilExecPassthru callsites in….

epriestley mentioned this in rARC8bb7d5889050: Deprecate "PhutilExecPassthru->execute()" in favor of "resolve()".

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

ssh-connect.php

2 lines

src/

applications/

repository/

storage/

PhabricatorRepository.php

4 lines

Diff 51689

scripts/ssh/ssh-connect.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...