Page MenuHomePhabricator

Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
ClosedPublic

Authored by epriestley on Jul 21 2021, 4:54 PM.

Details

Summary

Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it.

Test Plan
  • Grepped for "PhutilExecPassthru" and looked for callsites.
  • Ran GIT_SSH=.../ssh-connect git ls-remote origin to execute the "ssh-connect" code.
  • The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now.

Diff Detail

Repository
rP Phabricator
Branch
passthru1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25492
Build 35247: Run Core Tests
Build 35246: arc lint + arc unit