- Grepped for callsites.
- Ran arc patch --trace in a Git working copy and saw the updated "git apply" in the trace output.
- Used this test script (changing the method and the command invoked) to confirm that success and error behavior is identical in "resolve()" and "execute()", except that "execute()" now emits a deprecation warning:
<?php require_once 'support/init/init-script.php'; $err = id(new PhutilExecPassthru('lsx'))->execute(); var_dump($err);
Yeah, here's test.php running ls with execute():
$ php -f test.php [2021-07-21 10:01:26] PHLOG: 'The "execute()" method of "PhutilExecPassthru" is deprecated and calls should be replaced with "resolve()". See T13660.' at [/Users/epriestley/dev/core/lib/arcanist/src/future/exec/PhutilExecPassthru.php:36] LICENSE NOTICE README.md bin externals resources scripts src support test.php int(0)
It seems pretty unlikely that anyone is calling execute() and I'm usually not too dainty about breaking almost-certainly-only-internal APIs, but it was in the docblock.