Differential D21537

When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 4:54 PM.

Tags

None

Referenced Files

	F15458798: D21537.diff
	Mon, Mar 31, 7:26 AM

	F15447877: D21537.id51265.diff
	Fri, Mar 28, 2:08 AM

	F15446005: D21537.id51269.diff
	Thu, Mar 27, 4:54 PM

	F15444160: D21537.id51266.diff
	Thu, Mar 27, 8:12 AM

	F15441290: D21537.id.diff
	Wed, Mar 26, 5:21 PM

	F15434437: D21537.diff
	Tue, Mar 25, 3:40 AM

	Unknown Object (File)
	Feb 23 2025, 9:44 AM

	Unknown Object (File)
	Feb 19 2025, 1:08 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors
Commits: rARC08dbbbba5ade: When lint identifies an unknown symbol, attempt to correct it if it is…

Summary

Ref T13598. If you spell a symbol like "Polygon" as "PoLyGoN", you currently get an "unknown symbol" lint message. However, provided "Polygon" is a valid symbol, we can unambiguously correct the spelling of the symbol.

Note that this patch can only correct the spelling of application symbols, not builtin symbols (since none of the library maps contain builtin symbols).

Test Plan

Screen Shot 2021-02-03 at 8.50.07 AM.png (931×1 px, 388 KB)

Diff Detail

Repository

Branch

lint1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25080
Build 34606: Run Core Tests
Build 34605: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 3 2021, 4:54 PM

Harbormaster completed remote builds in B25079: Diff 51265.Feb 3 2021, 4:55 PM

epriestley requested review of this revision.Feb 3 2021, 4:55 PM

"Fix" ruby unit test error, which was a local environment issue.

Harbormaster completed remote builds in B25080: Diff 51266.Feb 3 2021, 4:58 PM

epriestley mentioned this in D21538: Allow lint to correct the spelling of builtin symbols.Feb 3 2021, 9:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 9:26 PM

Closed by commit rARC08dbbbba5ade: When lint identifies an unknown symbol, attempt to correct it if it is… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols.

epriestley added a commit: rARC08dbbbba5ade: When lint identifies an unknown symbol, attempt to correct it if it is….

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhutilLibraryLinter.php

186 lines

Diff 51266

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...