Page MenuHomePhabricator

When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized
ClosedPublic

Authored by epriestley on Feb 3 2021, 4:54 PM.
Tags
None
Referenced Files
F12815446: D21537.id51266.diff
Thu, Mar 28, 2:54 AM
Unknown Object (File)
Feb 9 2024, 6:07 PM
Unknown Object (File)
Feb 9 2024, 7:13 AM
Unknown Object (File)
Jan 28 2024, 10:28 PM
Unknown Object (File)
Jan 18 2024, 9:00 PM
Unknown Object (File)
Jan 5 2024, 1:16 PM
Unknown Object (File)
Dec 27 2023, 1:41 PM
Unknown Object (File)
Dec 27 2023, 1:40 PM
Subscribers
None

Details

Summary

Ref T13598. If you spell a symbol like "Polygon" as "PoLyGoN", you currently get an "unknown symbol" lint message. However, provided "Polygon" is a valid symbol, we can unambiguously correct the spelling of the symbol.

Note that this patch can only correct the spelling of application symbols, not builtin symbols (since none of the library maps contain builtin symbols).

Test Plan

Screen Shot 2021-02-03 at 8.50.07 AM.png (931×1 px, 388 KB)

Diff Detail

Repository
rARC Arcanist
Branch
lint1
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 25079
Build 34604: Run Core Tests
Build 34603: arc lint + arc unit

Unit TestsFailed

TimeTest
86 msArcanistRubyLinterTestCase::testLinter
Lint emitted an unexpected set of messages for file "wvswc.lint-test". MISSING MESSAGES (No messages.)
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
7 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNonTreeGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNoncyclicGraph
1 assertion(s) passed.
View Full Test Results (1 Failed · 494 Passed · 65 Skipped)