When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized
ClosedPublic
Actions

Authored by epriestley on Feb 3 2021, 4:54 PM.

Details

Reviewers: None
Maniphest Tasks: T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors
Commits: rARC08dbbbba5ade: When lint identifies an unknown symbol, attempt to correct it if it is…

Summary

Ref T13598. If you spell a symbol like "Polygon" as "PoLyGoN", you currently get an "unknown symbol" lint message. However, provided "Polygon" is a valid symbol, we can unambiguously correct the spelling of the symbol.

Note that this patch can only correct the spelling of application symbols, not builtin symbols (since none of the library maps contain builtin symbols).

Test Plan

Screen Shot 2021-02-03 at 8.50.07 AM.png (931×1 px, 388 KB)

Diff Detail

Repository

rARC Arcanist

Branch

lint1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25079
Build 34604: Run Core Tests
Build 34603: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	86 ms	ArcanistRubyLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "wvswc.lint-test". MISSING MESSAGES (No messages.)
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	7 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed.
		View Full Test Results (1 Failed · 494 Passed · 65 Skipped)