Page MenuHomePhabricator

Remove construction of "author" information from "LastModified" payload in Diffusion
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:05 PM.
Tags
None
Referenced Files
F18993521: D21404.id50947.diff
Wed, Nov 19, 8:10 AM
F18979283: D21404.id50947.diff
Sun, Nov 16, 9:41 PM
F18860811: D21404.id50947.diff
Sun, Nov 2, 12:59 PM
F18834194: D21404.id51021.diff
Sun, Oct 26, 7:06 AM
F18834193: D21404.id50947.diff
Sun, Oct 26, 7:06 AM
F18834192: D21404.id.diff
Sun, Oct 26, 7:06 AM
F18832488: D21404.diff
Sat, Oct 25, 10:00 PM
F18803408: D21404.id.diff
Oct 17 2025, 11:31 PM
Subscribers
None

Details

Summary

Ref T13552. When viewing a directory in Diffusion, we make an Ajax call to get the last commit for each path.

This call currently pulls author information, since an older version of this UI showed author information.

The current UI does not show author information, so this parameter is unused. Delete the code which builds it.

Test Plan

Grepped for 'author' and references to the "pull-lastmodified" behavior. This behavior is invoked in only one place, which never generates an author placeholder.

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24766
Build 34156: Run Core Tests
Build 34155: arc lint + arc unit