Page MenuHomePhabricator

Remove construction of "author" information from "LastModified" payload in Diffusion
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 9:41 PM
Unknown Object (File)
Sat, Nov 16, 8:29 PM
Unknown Object (File)
Wed, Nov 13, 5:28 PM
Unknown Object (File)
Sun, Nov 10, 12:30 AM
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Wed, Nov 6, 12:24 AM
Subscribers
None

Details

Summary

Ref T13552. When viewing a directory in Diffusion, we make an Ajax call to get the last commit for each path.

This call currently pulls author information, since an older version of this UI showed author information.

The current UI does not show author information, so this parameter is unused. Delete the code which builds it.

Test Plan

Grepped for 'author' and references to the "pull-lastmodified" behavior. This behavior is invoked in only one place, which never generates an author placeholder.

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24766
Build 34156: Run Core Tests
Build 34155: arc lint + arc unit