Page MenuHomePhabricator

Remove construction of "author" information from "LastModified" payload in Diffusion
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:05 PM.

Details

Summary

Ref T13552. When viewing a directory in Diffusion, we make an Ajax call to get the last commit for each path.

This call currently pulls author information, since an older version of this UI showed author information.

The current UI does not show author information, so this parameter is unused. Delete the code which builds it.

Test Plan

Grepped for 'author' and references to the "pull-lastmodified" behavior. This behavior is invoked in only one place, which never generates an author placeholder.

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24766
Build 34156: Run Core Tests
Build 34155: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.