Page MenuHomePhabricator
Differential D21357

When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 12:03 AM
Unknown Object (File)
Fri, Dec 20, 8:52 PM
Unknown Object (File)
Fri, Dec 20, 6:56 PM
Unknown Object (File)
Tue, Dec 17, 6:13 AM
Unknown Object (File)
Tue, Dec 17, 5:26 AM
Unknown Object (File)
Sun, Dec 15, 1:47 AM
Unknown Object (File)
Thu, Dec 12, 7:54 AM
Unknown Object (File)
Mon, Dec 9, 4:51 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal…
rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during…
Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository
rARC Arcanist
Branch
lint1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24656
Build 33997: Run Core Tests
Build 33996: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 12 2020, 7:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM
Harbormaster failed remote builds in B24655: Diff 50835!
epriestley updated this revision to Diff 50836.Jun 12 2020, 7:28 PM
  • Allow a linter to raise messages just past the very end of a file.
Harbormaster completed remote builds in B24656: Diff 50836.Jun 12 2020, 7:28 PM
epriestley requested review of this revision.Jun 12 2020, 7:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 7:31 PM
Closed by commit rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during….
epriestley added a commit: rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal….

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
35 lines

Diff 50836

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
Phabricator · Built by Phacility