Page MenuHomePhabricator

When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic

Authored by epriestley on Jun 12 2020, 7:11 PM.

Details

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository
rARC Arcanist
Branch
lint1
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 24655
Build 33995: Run Core Tests
Build 33994: arc lint + arc unit

Unit TestsFailed

TimeTest
23 msArcanistConsoleLintRendererTestCase::testRendering
Assertion failed, expected values to be equal (at ArcanistConsoleLintRendererTestCase.php:226): Lint rendering for "eofmultilineline". Expected vs Actual Output Diff --- Old Value
12 msArcanistConsoleLintRendererTestCase::testRendering
Assertion failed, expected values to be equal (at ArcanistConsoleLintRendererTestCase.php:226): Lint rendering for "eofmultilineline". Expected vs Actual Output Diff --- Old Value
0 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
1 assertion(s) passed.
0 msAbstractDirectedGraphTestCase::testNonTreeGraph
1 assertion(s) passed.
View Full Test Results (2 Failed · 470 Passed · 34 Skipped)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM
Harbormaster failed remote builds in B24655: Diff 50835!
  • Allow a linter to raise messages just past the very end of a file.