Page MenuHomePhabricator

When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic

Authored by epriestley on Jun 12 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 20, 8:52 AM
Unknown Object (File)
Thu, Jun 19, 10:57 AM
Unknown Object (File)
Wed, Jun 18, 7:06 AM
Unknown Object (File)
Thu, Jun 5, 5:00 PM
Unknown Object (File)
May 31 2025, 7:44 PM
Unknown Object (File)
May 29 2025, 7:32 AM
Unknown Object (File)
May 15 2025, 4:37 PM
Unknown Object (File)
Apr 27 2025, 12:43 AM
Subscribers
None

Details

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM
Harbormaster failed remote builds in B24655: Diff 50835!
  • Allow a linter to raise messages just past the very end of a file.