Page MenuHomePhabricator

When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic

Authored by epriestley on Jun 12 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 2:43 PM
Unknown Object (File)
Feb 19 2024, 1:20 PM
Unknown Object (File)
Feb 13 2024, 5:43 AM
Unknown Object (File)
Feb 12 2024, 2:15 AM
Unknown Object (File)
Dec 27 2023, 1:26 PM
Unknown Object (File)
Dec 27 2023, 1:39 AM
Unknown Object (File)
Dec 26 2023, 9:39 AM
Unknown Object (File)
Dec 22 2023, 3:02 AM
Subscribers
None

Details

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM
Harbormaster failed remote builds in B24655: Diff 50835!
  • Allow a linter to raise messages just past the very end of a file.