When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 7:11 PM.

Details

Reviewers: None
Commits: rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal…
rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during…

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM

epriestley requested review of this revision.Jun 12 2020, 7:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

lint/

renderer/

35 lines