When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 7:11 PM.

Details

Reviewers: None
Commits: rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal…
rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during…

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Diff Detail

Repository

rARC Arcanist

Branch

lint1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24656
Build 33997: Run Core Tests
Build 33996: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 12 2020, 7:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 12 2020, 7:12 PM

Harbormaster failed remote builds in B24655: Diff 50835!

Allow a linter to raise messages just past the very end of a file.

Harbormaster completed remote builds in B24656: Diff 50836.Jun 12 2020, 7:28 PM

epriestley requested review of this revision.Jun 12 2020, 7:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 7:31 PM

Closed by commit rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during….

epriestley added a commit: rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal….

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistConsoleLintRenderer.php

35 lines

Diff 50836

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

When a linter raises a message at a nonexistent line, don't fatal during renderingClosedPublicActions