When a linter raises a message at a nonexistent line, don't fatal during rendering
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 7:11 PM.

Details

Reviewers: None
Commits: rARCa798e740719b: (stable) When a linter raises a message at a nonexistent line, don't fatal…
rARC1e09a0ee7e91: When a linter raises a message at a nonexistent line, don't fatal during…

Summary

See PHI1782. If a linter raises a message at a line which does not exist in the file, render a confused warning rather than fataling.

This is a long-existing issue which was exacerbated by D21044.

Test Plan

Modified a linter to raise issues at line 99999. Before change: fatal in console rendering. After change: reasonable rendering.

Repository

rARC Arcanist

Branch

lint1

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	23 ms	ArcanistConsoleLintRendererTestCase::testRendering Assertion failed, expected values to be equal (at ArcanistConsoleLintRendererTestCase.php:226): Lint rendering for "eofmultilineline". Expected vs Actual Output Diff --- Old Value
	12 ms	ArcanistConsoleLintRendererTestCase::testRendering Assertion failed, expected values to be equal (at ArcanistConsoleLintRendererTestCase.php:226): Lint rendering for "eofmultilineline". Expected vs Actual Output Diff --- Old Value
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
		View Full Test Results (2 Failed · 470 Passed · 34 Skipped)