Differential D20865

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic
Actions

Authored by epriestley on Oct 25 2019, 6:47 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rP8ff0e3ab351f: Support rich diff rendering with DocumentEngine for added/removed files

Summary

Ref T13425. When a file (like a Jupyter notebook) is added or removed, we can still render a useful line-by-line diff.

Test Plan

Viewed add/modify/remove of Jupyter, source code, and images in 2up/1up mode, everything looked okay.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 25 2019, 6:47 PM

Screen Shot 2019-10-25 at 11.41.52 AM.png (1×1 px, 287 KB)

Harbormaster completed remote builds in B23567: Diff 49739.Oct 25 2019, 6:49 PM

epriestley requested review of this revision.Oct 25 2019, 6:49 PM

leoluk awarded a token.Oct 25 2019, 9:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2019, 3:21 PM

Closed by commit rP8ff0e3ab351f: Support rich diff rendering with DocumentEngine for added/removed files (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8ff0e3ab351f: Support rich diff rendering with DocumentEngine for added/removed files.

epriestley mentioned this in D20866: Fix an issue where added or removed source files could incorrectly select a DocumentEngine.Oct 26 2019, 7:09 PM

epriestley mentioned this in rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a….Oct 26 2019, 7:16 PM

epriestley mentioned this in rPf5b3528a2670: (stable) Fix an issue where added or removed source files could incorrectly….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

86 lines

render/

DifferentialChangesetOneUpRenderer.php

10 lines

files/

diff/

PhabricatorDocumentEngineBlocks.php

5 lines

document/

PhabricatorDocumentEngine.php

4 lines

PhabricatorImageDocumentEngine.php

33 lines

PhabricatorJupyterDocumentEngine.php

21 lines

Diff 49740

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

View Options

src/applications/files/document/PhabricatorDocumentEngine.php

View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Support rich diff rendering with DocumentEngine for added/removed filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49740

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/applications/files/document/PhabricatorDocumentEngine.php

src/applications/files/document/PhabricatorImageDocumentEngine.php

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic
Actions

Revision Contents
Changeset List