Page MenuHomePhabricator

Fix an issue where added or removed source files could incorrectly select a DocumentEngine
ClosedPublic

Authored by epriestley on Oct 26 2019, 7:09 PM.
Tags
None
Referenced Files
F18873630: D20866.id.diff
Wed, Nov 5, 10:43 AM
F18834058: D20866.diff
Sun, Oct 26, 6:52 AM
F18829729: D20866.id49742.diff
Sat, Oct 25, 12:29 AM
F18813773: D20866.diff
Mon, Oct 20, 6:54 PM
F18791307: D20866.diff
Thu, Oct 16, 9:04 AM
F18734083: D20866.id.diff
Sep 30 2025, 10:47 PM
F18646942: D20866.diff
Sep 19 2025, 11:45 AM
F18570965: D20866.id49743.diff
Sep 10 2025, 4:14 AM
Subscribers
None

Details

Summary

Ref T13425. The changes in D20865 could incorrectly lead to selection of a DocumentEngine that can not generate document diffs if a file was added or removed (for example, when a source file is added).

Move the engine pruning code to be shared -- we should always discard engines which can't generate a diff, even if we don't have both documents.

Test Plan

Viewed an added source file, no more document ref error arising from document engine selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable