Page MenuHomePhabricator
Differential D20866

Fix an issue where added or removed source files could incorrectly select a DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Oct 26 2019, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 2:24 PM
Unknown Object (File)
Thu, Dec 12, 4:36 AM
Unknown Object (File)
Sat, Nov 30, 5:48 PM
Unknown Object (File)
Sat, Nov 30, 5:18 PM
Unknown Object (File)
Wed, Nov 27, 5:08 PM
Unknown Object (File)
Wed, Nov 27, 1:09 AM
Unknown Object (File)
Tue, Nov 26, 4:21 AM
Unknown Object (File)
Nov 23 2024, 10:35 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPf5b3528a2670: (stable) Fix an issue where added or removed source files could incorrectly…
rP292f8fc612bd: Fix an issue where added or removed source files could incorrectly select a…
Summary

Ref T13425. The changes in D20865 could incorrectly lead to selection of a DocumentEngine that can not generate document diffs if a file was added or removed (for example, when a source file is added).

Move the engine pruning code to be shared -- we should always discard engines which can't generate a diff, even if we don't have both documents.

Test Plan

Viewed an added source file, no more document ref error arising from document engine selection.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
12 lines

Diff 49743

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
Phabricator · Built by Phacility