Page MenuHomePhabricator

Fix an issue where added or removed source files could incorrectly select a DocumentEngine
ClosedPublic

Authored by epriestley on Sat, Oct 26, 7:09 PM.

Details

Summary

Ref T13425. The changes in D20865 could incorrectly lead to selection of a DocumentEngine that can not generate document diffs if a file was added or removed (for example, when a source file is added).

Move the engine pruning code to be shared -- we should always discard engines which can't generate a diff, even if we don't have both documents.

Test Plan

Viewed an added source file, no more document ref error arising from document engine selection.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Oct 26, 7:09 PM
epriestley requested review of this revision.Sat, Oct 26, 7:11 PM