Page MenuHomePhabricator

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic

Authored by epriestley on Oct 25 2019, 6:47 PM.
Tags
None
Referenced Files
F18739236: D20865.diff
Wed, Oct 1, 8:29 PM
F18668913: D20865.id.diff
Wed, Sep 24, 5:00 PM
F18657492: D20865.diff
Tue, Sep 23, 2:06 AM
F18604480: D20865.diff
Sat, Sep 13, 6:54 PM
F18570963: D20865.id49740.diff
Wed, Sep 10, 4:14 AM
F18570962: D20865.id49739.diff
Wed, Sep 10, 4:14 AM
F18567480: D20865.id.diff
Tue, Sep 9, 3:49 PM
F18514266: D20865.id49739.diff
Fri, Sep 5, 10:07 AM
Subscribers
None
Tokens
"Love" token, awarded by leoluk.

Details

Summary

Ref T13425. When a file (like a Jupyter notebook) is added or removed, we can still render a useful line-by-line diff.

Test Plan
  • Viewed add/modify/remove of Jupyter, source code, and images in 2up/1up mode, everything looked okay.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23567
Build 32390: Run Core Tests
Build 32389: arc lint + arc unit