Page MenuHomePhabricator

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic

Authored by epriestley on Oct 25 2019, 6:47 PM.
Tags
None
Referenced Files
F13135276: D20865.id49740.diff
Thu, May 2, 7:54 AM
Unknown Object (File)
Wed, May 1, 8:09 PM
Unknown Object (File)
Tue, Apr 30, 9:51 AM
Unknown Object (File)
Sun, Apr 28, 10:56 PM
Unknown Object (File)
Sun, Apr 28, 9:31 AM
Unknown Object (File)
Sun, Apr 21, 10:27 AM
Unknown Object (File)
Sat, Apr 20, 4:57 PM
Unknown Object (File)
Wed, Apr 17, 3:15 PM
Subscribers
None
Tokens
"Love" token, awarded by leoluk.

Details

Summary

Ref T13425. When a file (like a Jupyter notebook) is added or removed, we can still render a useful line-by-line diff.

Test Plan
  • Viewed add/modify/remove of Jupyter, source code, and images in 2up/1up mode, everything looked okay.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23567
Build 32390: Run Core Tests
Build 32389: arc lint + arc unit