Page MenuHomePhabricator

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic

Authored by epriestley on Oct 25 2019, 6:47 PM.
Tags
None
Referenced Files
F14087915: D20865.id49740.diff
Sun, Nov 24, 12:36 AM
Unknown Object (File)
Thu, Nov 21, 7:18 PM
Unknown Object (File)
Oct 23 2024, 8:57 AM
Unknown Object (File)
Oct 17 2024, 4:00 AM
Unknown Object (File)
Oct 7 2024, 11:44 AM
Unknown Object (File)
Oct 7 2024, 12:12 AM
Unknown Object (File)
Oct 6 2024, 11:15 PM
Unknown Object (File)
Oct 6 2024, 9:32 PM
Subscribers
None
Tokens
"Love" token, awarded by leoluk.

Details

Summary

Ref T13425. When a file (like a Jupyter notebook) is added or removed, we can still render a useful line-by-line diff.

Test Plan
  • Viewed add/modify/remove of Jupyter, source code, and images in 2up/1up mode, everything looked okay.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23567
Build 32390: Run Core Tests
Build 32389: arc lint + arc unit