Page MenuHomePhabricator

Support rich diff rendering with DocumentEngine for added/removed files
ClosedPublic

Authored by epriestley on Oct 25 2019, 6:47 PM.
Tags
None
Referenced Files
F15460831: D20865.id49739.diff
Tue, Apr 1, 2:46 AM
F15454387: D20865.id.diff
Sat, Mar 29, 6:20 PM
F15453850: D20865.id49740.diff
Sat, Mar 29, 2:51 PM
F15446545: D20865.diff
Thu, Mar 27, 7:32 PM
F15414385: D20865.diff
Thu, Mar 20, 12:22 AM
Unknown Object (File)
Feb 24 2025, 4:04 AM
Unknown Object (File)
Feb 18 2025, 9:06 AM
Unknown Object (File)
Feb 13 2025, 4:08 PM
Subscribers
None
Tokens
"Love" token, awarded by leoluk.

Details

Summary

Ref T13425. When a file (like a Jupyter notebook) is added or removed, we can still render a useful line-by-line diff.

Test Plan
  • Viewed add/modify/remove of Jupyter, source code, and images in 2up/1up mode, everything looked okay.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23567
Build 32390: Run Core Tests
Build 32389: arc lint + arc unit