Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:07 PM.
Tags
None
Referenced Files
F19812131: D20858.diff
Wed, Mar 4, 3:47 AM
F19616987: D20858.diff
Feb 4 2026, 4:15 AM
F19616981: D20858.diff
Feb 4 2026, 4:12 AM
F19358605: D20858.id49727.diff
Dec 26 2025, 8:15 AM
F19318208: D20858.id49727.diff
Dec 25 2025, 6:28 AM
F19083100: D20858.id49727.diff
Dec 2 2025, 12:30 PM
F19035678: D20858.id.diff
Nov 25 2025, 5:40 PM
F19025975: D20858.diff
Nov 24 2025, 9:16 AM
Subscribers
None

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.