Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13428: PHP 7.4 now warns about "implode()" argument order
- Commits
- rP5dafabd5b4d0: Fix deprecated argument order for "implode()"
Used the linter introduced in D20857 to identify affected callsites.
$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glueDiff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- implode1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 23553 Build 32369: Run Core Tests Build 32368: arc lint + arc unit