Page MenuHomePhabricator

Fix deprecated argument order for "implode()"
ClosedPublic

Authored by epriestley on Oct 17 2019, 4:07 PM.
Tags
None
Referenced Files
F13179526: D20858.diff
Wed, May 8, 9:15 PM
F13175879: D20858.id.diff
Wed, May 8, 8:23 AM
Unknown Object (File)
Sat, May 4, 6:49 PM
Unknown Object (File)
Wed, May 1, 8:08 PM
Unknown Object (File)
Wed, May 1, 12:13 AM
Unknown Object (File)
Thu, Apr 18, 7:40 PM
Unknown Object (File)
Thu, Apr 11, 9:28 AM
Unknown Object (File)
Mar 31 2024, 10:55 PM
Subscribers
None

Details

Summary

Fixes T13428. In modern PHP, "implode()" should take the glue parameter first.

Test Plan

Used the linter introduced in D20857 to identify affected callsites.

$ git grep -i implode | cut -d: -f1 | sort | uniq | xargs arc lint --output summary --never-apply-patches | grep -i glue

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2019, 4:11 PM
This revision was automatically updated to reflect the committed changes.