Differential D20848

Force unified abstract block diffs into roughly usable shape
ClosedPublic
Actions

Authored by epriestley on Sep 30 2019, 5:34 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rP76d9912932bc: Force unified abstract block diffs into roughly usable shape

Summary

Depends on D20845. Ref T13425. In unified mode, render blocks diffs less-unreasonably.

Test Plan

Screen Shot 2019-09-30 at 10.33.48 AM.png (327×958 px, 36 KB)

Diff Detail

Repository

rP Phabricator

Branch

jupyter4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:361	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23521
Build 32328: Run Core Tests
Build 32327: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 30 2019, 5:34 PM

Harbormaster completed remote builds in B23521: Diff 49694.Sep 30 2019, 5:36 PM

epriestley requested review of this revision.Sep 30 2019, 5:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 5:44 PM

Closed by commit rP76d9912932bc: Force unified abstract block diffs into roughly usable shape (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP76d9912932bc: Force unified abstract block diffs into roughly usable shape.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

245 lines

infrastructure/

diff/

view/

PHUIDiffOneUpInlineCommentRowScaffold.php

3 lines

Diff 49694

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php