Page MenuHomePhabricator

When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Fri, Jan 17, 5:50 PM
Unknown Object (File)
Dec 13 2024, 5:00 PM
Unknown Object (File)
Dec 5 2024, 5:53 AM
Unknown Object (File)
Nov 9 2024, 3:39 PM
Unknown Object (File)
Oct 18 2024, 3:11 PM
Unknown Object (File)
Oct 18 2024, 9:07 AM
Unknown Object (File)
Oct 18 2024, 12:14 AM
Subscribers
None

Details

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan
  • With "mysql.port" set to "quack", ran bin/storage probe.
  • Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
  • After: clean connection failure with a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable