Page MenuHomePhabricator

When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic

Authored by epriestley on Sep 3 2019, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:29 AM
Unknown Object (File)
Fri, Apr 19, 2:32 AM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Mon, Apr 1, 10:46 PM
Unknown Object (File)
Mon, Apr 1, 8:46 AM
Unknown Object (File)
Mar 3 2024, 10:42 AM
Unknown Object (File)
Jan 21 2024, 3:42 PM
Unknown Object (File)
Jan 16 2024, 5:14 PM
Subscribers
None

Details

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan
  • With "mysql.port" set to "quack", ran bin/storage probe.
  • Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
  • After: clean connection failure with a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable