Details
Details
- With "mysql.port" set to "quack", ran bin/storage probe.
- Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
- After: clean connection failure with a useful error message.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- config2
- Lint
Lint Errors Severity Location Code Message Error src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:135 XHP45 PHP Compatibility Error src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:245 XHP45 PHP Compatibility - Unit
Tests Passed - Build Status
Buildable 23373 Build 32108: Run Core Tests Build 32107: arc lint + arc unit