When "mysqli->real_connect()" fails without setting an error code, recover more gracefully
ClosedPublic
Actions

Authored by epriestley on Sep 3 2019, 7:23 PM.

Details

Reviewers: None
Maniphest Tasks: T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues
Commits: rPf8eec38c9419: When "mysqli->real_connect()" fails without setting an error code, recover more…

Summary

Depends on D20779. Ref T13403. Bad parameters may cause this call to fail without setting an error code; if it does, catch the issue and go down the normal connection error pathway.

Test Plan

With "mysql.port" set to "quack", ran bin/storage probe.
Before: wild mess of warnings as the code continued below and failed when trying to interact with the connection.
After: clean connection failure with a useful error message.

Diff Detail

Repository

rP Phabricator

Branch

config2

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:135	XHP45	PHP Compatibility
Error	src/infrastructure/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:245	XHP45	PHP Compatibility

Unit