Differential D20697

Refactor the Phortune account detail page into a series of smaller, more focused sections
ClosedPublic
Actions

Authored by epriestley on Aug 2 2019, 6:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13366: Update Phortune to work better with "enterprise" billing/accounts departments
Commits: rP719a7d82c51f: Refactor the Phortune account detail page into a series of smaller, more…

Summary

Ref T13366. Some of the information architecture is a little muddy here, notably an item called "Billing / History" which contains payment methods.

Split things up a bit to prepare for adding support for "Email Addresses".

Test Plan

Screen Shot 2019-08-02 at 11.51.57 AM.png (1×1 px, 265 KB)

Diff Detail

Repository

rP Phabricator

Branch

merchant2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23226
Build 31904: Run Core Tests
Build 31903: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 2 2019, 6:55 PM

Harbormaster completed remote builds in B23226: Diff 49361.Aug 2 2019, 6:57 PM

epriestley requested review of this revision.Aug 2 2019, 6:57 PM

epriestley added a child revision: D20713: Add scaffolding for ad-hoc email addresses associated with Phortune accounts.Aug 12 2019, 10:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 3:56 AM

Closed by commit rP719a7d82c51f: Refactor the Phortune account detail page into a series of smaller, more… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP719a7d82c51f: Refactor the Phortune account detail page into a series of smaller, more….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

phortune/

application/

PhabricatorPhortuneApplication.php

22 lines

controller/

account/

PhortuneAccountAddManagerController.php

8 lines

PhortuneAccountBillingController.php

PhortuneAccountChargesController.php

79 lines

PhortuneAccountDetailsController.php

132 lines

PhortuneAccountManagerController.php

	PhortuneAccountManagersController.php
	PhortuneAccountManagerController.php

6 lines

PhortuneAccountOrdersController.php

37 lines

	PhortuneAccountOverviewController.php
	PhortuneAccountViewController.php

118 lines

	PhortuneAccountPaymentMethodsController.php
	PhortuneAccountBillingController.php

59 lines

PhortuneAccountProfileController.php

89 lines

PhortuneAccountViewController.php

editor/

PhortuneAccountEditEngine.php

6 lines

storage/

PhortuneAccount.php

6 lines

Diff 49361

View Options

src/__phutil_library_map__.php

View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

View Options

src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountBillingController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountChargesController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountDetailsController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountManagerController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountManagersController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountOrdersController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountOverviewController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodsController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountViewController.php

View Options

src/applications/phortune/editor/PhortuneAccountEditEngine.php

View Options

src/applications/phortune/storage/PhortuneAccount.php

Refactor the Phortune account detail page into a series of smaller, more focused sectionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49361

src/__phutil_library_map__.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phortune/controller/account/PhortuneAccountAddManagerController.php

src/applications/phortune/controller/account/PhortuneAccountBillingController.php

src/applications/phortune/controller/account/PhortuneAccountChargesController.php

src/applications/phortune/controller/account/PhortuneAccountDetailsController.php

src/applications/phortune/controller/account/PhortuneAccountManagerController.php

src/applications/phortune/controller/account/PhortuneAccountManagersController.php

src/applications/phortune/controller/account/PhortuneAccountOrdersController.php

src/applications/phortune/controller/account/PhortuneAccountOverviewController.php

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodsController.php

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

src/applications/phortune/controller/account/PhortuneAccountViewController.php

src/applications/phortune/editor/PhortuneAccountEditEngine.php

src/applications/phortune/storage/PhortuneAccount.php

Refactor the Phortune account detail page into a series of smaller, more focused sections
ClosedPublic
Actions

Revision Contents
Changeset List