Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F13187192: D20623.diff
Sat, May 11, 4:23 AM
Unknown Object (File)
Tue, May 7, 7:29 AM
Unknown Object (File)
Sat, May 4, 9:19 AM
Unknown Object (File)
Fri, May 3, 1:48 PM
Unknown Object (File)
Fri, May 3, 6:23 AM
Unknown Object (File)
Thu, May 2, 4:41 PM
Unknown Object (File)
Thu, May 2, 3:29 PM
Unknown Object (File)
Sat, Apr 27, 12:03 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable