Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F13050888: D20623.id49202.diff
Fri, Apr 19, 3:15 AM
F13050887: D20623.id49201.diff
Fri, Apr 19, 3:15 AM
F13050886: D20623.id.diff
Fri, Apr 19, 3:15 AM
Unknown Object (File)
Thu, Apr 11, 4:22 AM
Unknown Object (File)
Wed, Apr 3, 9:25 PM
Unknown Object (File)
Tue, Apr 2, 1:57 AM
Unknown Object (File)
Sat, Mar 30, 8:16 AM
Unknown Object (File)
Sat, Mar 30, 8:16 AM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable