Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F19670551: D20623.diff
Sat, Feb 7, 11:33 PM
F19559620: D20623.diff
Sat, Jan 31, 2:25 AM
F19518636: D20623.id.diff
Jan 15 2026, 10:03 PM
F19516260: D20623.diff
Jan 14 2026, 9:58 PM
F19089500: D20623.id49202.diff
Dec 3 2025, 7:31 AM
F18853608: D20623.diff
Oct 31 2025, 6:15 PM
F18768929: D20623.diff
Oct 8 2025, 5:55 AM
F18767197: D20623.id.diff
Oct 7 2025, 9:12 PM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Branch
href2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23070
Build 31669: Run Core Tests
Build 31668: arc lint + arc unit