Paths

Table of Contentst

Differential D20623

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic
Actions

Authored by epriestley on Jun 28 2019, 3:43 PM.

Details

Reviewers

amckinley

Commits

rPd6dc5d8e68bf: Fix the "x" link in tokenizer tokens incorrectly closing dialogs

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository

rP Phabricator

Branch

href2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23070
Build 31669: Run Core Tests
Build 31668: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 28 2019, 3:43 PM

Harbormaster completed remote builds in B23070: Diff 49201.Jun 28 2019, 3:44 PM

epriestley requested review of this revision.Jun 28 2019, 3:44 PM

ayyyyy

This revision is now accepted and ready to land.Jun 28 2019, 7:37 PM

Closed by commit rPd6dc5d8e68bf: Fix the "x" link in tokenizer tokens incorrectly closing dialogs (authored by epriestley). · Explain WhyJun 28 2019, 7:38 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd6dc5d8e68bf: Fix the "x" link in tokenizer tokens incorrectly closing dialogs.

krisbuist awarded a token.Jun 29 2019, 2:54 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

externals/

javelin/

lib/

Workflow.js

6 lines

Diff 49201

View Options

resources/celerity/map.php