Page MenuHomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs
ClosedPublic

Authored by epriestley on Jun 28 2019, 3:43 PM.
Tags
None
Referenced Files
F13225615: D20623.diff
Sun, May 19, 4:15 PM
F13221794: D20623.diff
Sun, May 19, 3:03 AM
F13219145: D20623.id49202.diff
Sat, May 18, 3:44 PM
F13214987: D20623.diff
Fri, May 17, 2:10 PM
F13204317: D20623.diff
Wed, May 15, 12:28 AM
F13194254: D20623.id.diff
Sun, May 12, 9:26 PM
F13187192: D20623.diff
Sat, May 11, 4:23 AM
Unknown Object (File)
Tue, May 7, 7:29 AM
Subscribers
None
Tokens
"Like" token, awarded by krisbuist.

Details

Summary

See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan

Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Diff Detail

Repository
rP Phabricator
Branch
href2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23070
Build 31669: Run Core Tests
Build 31668: arc lint + arc unit