Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
F13141625: D20572.diff
Fri, May 3, 5:02 AM
Unknown Object (File)
Sun, Apr 28, 1:10 AM
Unknown Object (File)
Sat, Apr 27, 6:51 AM
Unknown Object (File)
Fri, Apr 26, 9:38 PM
Unknown Object (File)
Thu, Apr 25, 12:44 AM
Unknown Object (File)
Thu, Apr 11, 8:34 AM
Unknown Object (File)
Fri, Apr 5, 6:46 PM
Unknown Object (File)
Mar 29 2024, 3:13 PM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable