Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 17 2024, 10:31 AM
Unknown Object (File)
Dec 27 2023, 10:49 PM
Unknown Object (File)
Dec 27 2023, 3:41 PM
Unknown Object (File)
Dec 24 2023, 8:58 PM
Unknown Object (File)
Dec 22 2023, 2:22 AM
Unknown Object (File)
Dec 17 2023, 4:32 PM
Unknown Object (File)
Dec 15 2023, 12:30 PM
Unknown Object (File)
Nov 30 2023, 6:24 AM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Branch
backup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22950
Build 31493: Run Core Tests
Build 31492: arc lint + arc unit