Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
F14083421: D20572.diff
Sat, Nov 23, 4:16 AM
F14080889: D20572.diff
Fri, Nov 22, 5:17 PM
Unknown Object (File)
Mon, Nov 18, 11:24 AM
Unknown Object (File)
Thu, Nov 14, 12:52 PM
Unknown Object (File)
Tue, Nov 12, 11:31 PM
Unknown Object (File)
Mon, Nov 11, 4:52 AM
Unknown Object (File)
Sun, Nov 10, 1:29 AM
Unknown Object (File)
Sat, Nov 9, 3:33 PM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable