Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
F13274698: D20572.diff
Fri, May 31, 4:00 AM
F13260755: D20572.diff
Mon, May 27, 12:20 AM
F13243152: D20572.diff
Thu, May 23, 3:25 AM
F13240002: D20572.diff
Wed, May 22, 9:08 AM
F13239450: D20572.id49109.diff
Wed, May 22, 3:07 AM
F13221524: D20572.diff
Sun, May 19, 2:50 AM
F13203927: D20572.diff
Wed, May 15, 12:13 AM
F13186811: D20572.diff
Sat, May 11, 4:03 AM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Branch
backup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22950
Build 31493: Run Core Tests
Build 31492: arc lint + arc unit