Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
F19509323: D20572.diff
Sat, Jan 10, 6:02 PM
F19119371: D20572.id49075.diff
Dec 9 2025, 8:44 PM
F19087744: D20572.diff
Dec 3 2025, 2:03 AM
F19081146: D20572.diff
Dec 2 2025, 4:15 AM
F19081116: D20572.diff
Dec 2 2025, 4:11 AM
F19081098: D20572.diff
Dec 2 2025, 4:08 AM
F19081034: D20572.diff
Dec 2 2025, 3:41 AM
F19044947: D20572.diff
Nov 27 2025, 5:28 AM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Branch
backup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22950
Build 31493: Run Core Tests
Build 31492: arc lint + arc unit