Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on May 30 2019, 5:15 PM.
Tags
None
Referenced Files
F15409874: D20561.diff
Wed, Mar 19, 5:44 AM
F15409454: D20561.diff
Wed, Mar 19, 4:32 AM
F15409124: D20561.diff
Wed, Mar 19, 3:20 AM
F15408903: D20561.diff
Wed, Mar 19, 2:07 AM
F15408727: D20561.diff
Wed, Mar 19, 12:54 AM
F15408535: D20561.diff
Tue, Mar 18, 11:42 PM
F15408351: D20561.diff
Tue, Mar 18, 10:30 PM
F15408109: D20561.diff
Tue, Mar 18, 9:18 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Screen Shot 2019-05-30 at 10.11.35 AM.png (478×616 px, 95 KB)

Diff Detail

Repository
rP Phabricator
Branch
maillink1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22927
Build 31455: Run Core Tests
Build 31454: arc lint + arc unit

Event Timeline

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.May 30 2019, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.