Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on May 30 2019, 5:15 PM.
Tags
None
Referenced Files
F20632465: D20561.diff
Sat, Jun 20, 7:04 PM
Unknown Object (File)
Thu, Jun 18, 12:04 AM
Unknown Object (File)
Apr 11 2026, 11:40 PM
Unknown Object (File)
Mar 8 2026, 5:54 AM
Unknown Object (File)
Feb 28 2026, 6:31 PM
Unknown Object (File)
Feb 13 2026, 2:55 AM
Unknown Object (File)
Feb 12 2026, 12:07 AM
Unknown Object (File)
Feb 11 2026, 4:09 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Screen Shot 2019-05-30 at 10.11.35 AM.png (478×616 px, 95 KB)

Diff Detail

Repository
rP Phabricator
Branch
maillink1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22927
Build 31455: Run Core Tests
Build 31454: arc lint + arc unit

Event Timeline

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.May 30 2019, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.