Page MenuHomePhabricator

Add a "View Task" button to HTML mail from Maniphest
ClosedPublic

Authored by epriestley on May 30 2019, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 4:32 PM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Sat, Mar 23, 7:22 AM
Unknown Object (File)
Sat, Mar 23, 7:21 AM
Unknown Object (File)
Feb 5 2024, 3:19 PM
Unknown Object (File)
Feb 2 2024, 12:29 PM
Unknown Object (File)
Jan 17 2024, 11:49 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T1050. Some time ago, we added a "View Revision" button to Differential mail. This hasn't created any problems and generally seems good / desirable.

It isn't trivial to just add everywhere since we need a translation string in each case, but at least add it to Maniphest for now. Going forward, we can fill in more applications as they come up.

Test Plan

Used bin/mail show-outbound --id <x> --dump-html:

Screen Shot 2019-05-30 at 10.11.35 AM.png (478×616 px, 95 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

This revision is now accepted and ready to land.May 30 2019, 7:06 PM

Oh, sure, that's pretty reasonable.

  • Share more API in Differential.
  • Add support in Diffusion for good measure.